Move Case Light to LEDs submenu (#18290)

This commit is contained in:
ManuelMcLure 2020-06-13 14:29:43 -07:00 committed by GitHub
parent 2668288e6c
commit 3e5158c430
Signed by: GitHub
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 69 additions and 68 deletions

View file

@ -269,24 +269,6 @@ void menu_advanced_settings();
#endif #endif
#if ENABLED(CASE_LIGHT_MENU)
#include "../../feature/caselight.h"
#if DISABLED(CASE_LIGHT_NO_BRIGHTNESS)
void menu_case_light() {
START_MENU();
BACK_ITEM(MSG_CONFIGURATION);
EDIT_ITEM(percent, MSG_CASE_LIGHT_BRIGHTNESS, &case_light_brightness, 0, 255, update_case_light, true);
EDIT_ITEM(bool, MSG_CASE_LIGHT, (bool*)&case_light_on, update_case_light);
END_MENU();
}
#endif
#endif
#if ENABLED(FWRETRACT) #if ENABLED(FWRETRACT)
#include "../../feature/fwretract.h" #include "../../feature/fwretract.h"
@ -403,18 +385,6 @@ void menu_configuration() {
#endif #endif
#endif #endif
//
// Set Case light on/off/brightness
//
#if ENABLED(CASE_LIGHT_MENU)
#if DISABLED(CASE_LIGHT_NO_BRIGHTNESS)
if (TERN1(CASE_LIGHT_USE_NEOPIXEL, PWM_PIN(CASE_LIGHT_PIN)))
SUBMENU(MSG_CASE_LIGHT, menu_case_light);
else
#endif
EDIT_ITEM(bool, MSG_CASE_LIGHT, (bool*)&case_light_on, update_case_light);
#endif
#if HAS_LCD_CONTRAST #if HAS_LCD_CONTRAST
EDIT_ITEM(int3, MSG_CONTRAST, &ui.contrast, LCD_CONTRAST_MIN, LCD_CONTRAST_MAX, ui.refresh_contrast, true); EDIT_ITEM(int3, MSG_CONTRAST, &ui.contrast, LCD_CONTRAST_MIN, LCD_CONTRAST_MAX, ui.refresh_contrast, true);
#endif #endif

View file

@ -26,13 +26,14 @@
#include "../../inc/MarlinConfigPre.h" #include "../../inc/MarlinConfigPre.h"
#if BOTH(HAS_LCD_MENU, LED_CONTROL_MENU) #if HAS_LCD_MENU && EITHER(LED_CONTROL_MENU, CASE_LIGHT_MENU)
#include "menu.h" #include "menu.h"
#include "../../feature/leds/leds.h"
#if ENABLED(LED_COLOR_PRESETS) #if ENABLED(LED_CONTROL_MENU)
#include "../../feature/leds/leds.h"
#if ENABLED(LED_COLOR_PRESETS)
void menu_led_presets() { void menu_led_presets() {
START_MENU(); START_MENU();
#if LCD_HEIGHT > 2 #if LCD_HEIGHT > 2
@ -50,9 +51,9 @@
END_MENU(); END_MENU();
} }
#endif #endif
void menu_led_custom() { void menu_led_custom() {
START_MENU(); START_MENU();
BACK_ITEM(MSG_LED_CONTROL); BACK_ITEM(MSG_LED_CONTROL);
EDIT_ITEM(uint8, MSG_INTENSITY_R, &leds.color.r, 0, 255, leds.update, true); EDIT_ITEM(uint8, MSG_INTENSITY_R, &leds.color.r, 0, 255, leds.update, true);
@ -65,11 +66,29 @@ void menu_led_custom() {
#endif #endif
#endif #endif
END_MENU(); END_MENU();
} }
#endif
#if ENABLED(CASE_LIGHT_MENU)
#include "../../feature/caselight.h"
#if DISABLED(CASE_LIGHT_NO_BRIGHTNESS)
void menu_case_light() {
START_MENU();
BACK_ITEM(MSG_CONFIGURATION);
EDIT_ITEM(percent, MSG_CASE_LIGHT_BRIGHTNESS, &case_light_brightness, 0, 255, update_case_light, true);
EDIT_ITEM(bool, MSG_CASE_LIGHT, (bool*)&case_light_on, update_case_light);
END_MENU();
}
#endif
#endif
void menu_led() { void menu_led() {
START_MENU(); START_MENU();
BACK_ITEM(MSG_MAIN); BACK_ITEM(MSG_MAIN);
#if ENABLED(LED_CONTROL_MENU)
bool led_on = leds.lights_on; bool led_on = leds.lights_on;
EDIT_ITEM(bool, MSG_LEDS, &led_on, leds.toggle); EDIT_ITEM(bool, MSG_LEDS, &led_on, leds.toggle);
ACTION_ITEM(MSG_SET_LEDS_DEFAULT, leds.set_default); ACTION_ITEM(MSG_SET_LEDS_DEFAULT, leds.set_default);
@ -77,6 +96,18 @@ void menu_led() {
SUBMENU(MSG_LED_PRESETS, menu_led_presets); SUBMENU(MSG_LED_PRESETS, menu_led_presets);
#endif #endif
SUBMENU(MSG_CUSTOM_LEDS, menu_led_custom); SUBMENU(MSG_CUSTOM_LEDS, menu_led_custom);
#endif
//
// Set Case light on/off/brightness
//
#if ENABLED(CASE_LIGHT_MENU)
#if DISABLED(CASE_LIGHT_NO_BRIGHTNESS)
if (TERN1(CASE_LIGHT_USE_NEOPIXEL, PWM_PIN(CASE_LIGHT_PIN)))
SUBMENU(MSG_CASE_LIGHT, menu_case_light);
else
#endif
EDIT_ITEM(bool, MSG_CASE_LIGHT, (bool*)&case_light_on, update_case_light);
#endif
END_MENU(); END_MENU();
} }

View file

@ -68,7 +68,7 @@ void menu_configuration();
void menu_info(); void menu_info();
#endif #endif
#if ENABLED(LED_CONTROL_MENU) #if EITHER(LED_CONTROL_MENU, CASE_LIGHT_MENU)
void menu_led(); void menu_led();
#endif #endif
@ -188,8 +188,8 @@ void menu_main() {
SUBMENU(MSG_INFO_MENU, menu_info); SUBMENU(MSG_INFO_MENU, menu_info);
#endif #endif
#if ENABLED(LED_CONTROL_MENU) #if EITHER(LED_CONTROL_MENU, CASE_LIGHT_MENU)
SUBMENU(MSG_LED_CONTROL, menu_led); SUBMENU(MSG_LEDS, menu_led);
#endif #endif
// //