From 65270d6a96900a56aa02609bb0fd0b8605f576fa Mon Sep 17 00:00:00 2001 From: Scott Lahteine Date: Sat, 19 May 2018 18:19:03 -0500 Subject: [PATCH] Fix LIN_ADVANCE + SWITCHING_EXTRUDER Followup to #10656 --- Marlin/src/module/stepper.cpp | 56 ++++++++++++++++++++++++----------- 1 file changed, 39 insertions(+), 17 deletions(-) diff --git a/Marlin/src/module/stepper.cpp b/Marlin/src/module/stepper.cpp index 60bba7a6e..ed4139086 100644 --- a/Marlin/src/module/stepper.cpp +++ b/Marlin/src/module/stepper.cpp @@ -1646,29 +1646,51 @@ void Stepper::isr() { #elif ENABLED(DUAL_X_CARRIAGE) || ENABLED(DUAL_NOZZLE_DUPLICATION_MODE) #define SET_E_STEP_DIR(INDEX) do{ if (e_steps) { if (e_steps < 0) REV_E_DIR(); else NORM_E_DIR(); } }while(0) #elif ENABLED(SWITCHING_EXTRUDER) - #define SET_E_STEP_DIR(INDEX) do{ if (e_steps) { switch (INDEX) { \ - case 0: case 1: E0_DIR_WRITE(!INVERT_E0_DIR ^ TEST(INDEX, 0) ^ (e_steps < 0)); break; \ - case 2: case 3: E1_DIR_WRITE(!INVERT_E1_DIR ^ TEST(INDEX, 0) ^ (e_steps < 0)); break; \ - case 4: E2_DIR_WRITE(!INVERT_E2_DIR ^ TEST(INDEX, 0) ^ (e_steps < 0)); \ - } } }while(0) + #if EXTRUDERS > 4 + #define SET_E_STEP_DIR(INDEX) do{ if (e_steps) { switch (INDEX) { \ + case 0: case 1: E0_DIR_WRITE(!INVERT_E0_DIR ^ TEST(INDEX, 0) ^ (e_steps < 0)); break; \ + case 2: case 3: E1_DIR_WRITE(!INVERT_E1_DIR ^ TEST(INDEX, 0) ^ (e_steps < 0)); break; \ + case 4: E2_DIR_WRITE(!INVERT_E2_DIR ^ TEST(INDEX, 0) ^ (e_steps < 0)); \ + } } }while(0) + #elif EXTRUDERS > 2 + #define SET_E_STEP_DIR(INDEX) do{ if (e_steps) { switch (INDEX) { \ + case 0: case 1: E0_DIR_WRITE(!INVERT_E0_DIR ^ TEST(INDEX, 0) ^ (e_steps < 0)); break; \ + case 2: case 3: E1_DIR_WRITE(!INVERT_E1_DIR ^ TEST(INDEX, 0) ^ (e_steps < 0)); break; \ + } } }while(0) + #else + #define SET_E_STEP_DIR(INDEX) do{ if (e_steps) E0_DIR_WRITE(!INVERT_E0_DIR ^ TEST(INDEX, 0) ^ (e_steps < 0)); }while(0) + #endif #else - #define SET_E_STEP_DIR(INDEX) do{ if (e_steps) E## INDEX ##_DIR_WRITE(e_steps < 0 ? INVERT_E## INDEX ##_DIR : !INVERT_E## INDEX ##_DIR); }while(0) + #define SET_E_STEP_DIR(INDEX) do{ if (e_steps) E## INDEX ##_DIR_WRITE(!INVERT_E## INDEX ##_DIR ^ (e_steps < 0)); }while(0) #endif #if ENABLED(DUAL_X_CARRIAGE) || ENABLED(DUAL_NOZZLE_DUPLICATION_MODE) #define START_E_PULSE(INDEX) do{ if (e_steps) E_STEP_WRITE(!INVERT_E_STEP_PIN); }while(0) - #define STOP_E_PULSE(INDEX) do{ if (e_steps) { E_STEP_WRITE(INVERT_E_STEP_PIN); e_steps < 0 ? ++e_steps : --e_steps; } }while(0) + #define STOP_E_PULSE(INDEX) do{ if (e_steps) { e_steps < 0 ? ++e_steps : --e_steps; E_STEP_WRITE(INVERT_E_STEP_PIN); } }while(0) #elif ENABLED(SWITCHING_EXTRUDER) - #define START_E_PULSE(INDEX) do{ if (e_steps) { switch (INDEX) { \ - case 0: case 1: E0_DIR_WRITE(!INVERT_E_STEP_PIN); break; \ - case 2: case 3: E1_DIR_WRITE(!INVERT_E_STEP_PIN); break; \ - case 4: E2_DIR_WRITE(!INVERT_E_STEP_PIN); \ - } } }while(0) - #define STOP_E_PULSE(INDEX) do{ if (e_steps) { switch (INDEX) { \ - case 0: case 1: E0_DIR_WRITE(!INVERT_E_STEP_PIN); break; \ - case 2: case 3: E1_DIR_WRITE(!INVERT_E_STEP_PIN); break; \ - case 4: E2_DIR_WRITE(!INVERT_E_STEP_PIN); \ - } } }while(0) + #if EXTRUDERS > 4 + #define START_E_PULSE(INDEX) do{ if (e_steps) { switch (INDEX) { \ + case 0: case 1: E0_DIR_WRITE(!INVERT_E_STEP_PIN); break; \ + case 2: case 3: E1_DIR_WRITE(!INVERT_E_STEP_PIN); break; \ + case 4: E2_DIR_WRITE(!INVERT_E_STEP_PIN); } \ + } }while(0) + #define STOP_E_PULSE(INDEX) do{ if (e_steps) { \ + e_steps < 0 ? ++e_steps : --e_steps; \ + switch (INDEX) { \ + case 0: case 1: E0_DIR_WRITE(INVERT_E_STEP_PIN); break; \ + case 2: case 3: E1_DIR_WRITE(INVERT_E_STEP_PIN); break; \ + case 4: E2_DIR_WRITE(INVERT_E_STEP_PIN); } \ + } }while(0) + #elif EXTRUDERS > 2 + #define START_E_PULSE(INDEX) do{ if (e_steps) { if (INDEX < 2) E0_DIR_WRITE(!INVERT_E_STEP_PIN); else E1_DIR_WRITE(!INVERT_E_STEP_PIN); } }while(0) + #define STOP_E_PULSE(INDEX) do{ if (e_steps) { \ + e_steps < 0 ? ++e_steps : --e_steps; \ + if (INDEX < 2) E0_DIR_WRITE(INVERT_E_STEP_PIN); else E1_DIR_WRITE(INVERT_E_STEP_PIN); \ + } }while(0) + #else + #define START_E_PULSE(INDEX) do{ if (e_steps) E0_DIR_WRITE(!INVERT_E_STEP_PIN); }while(0) + #define STOP_E_PULSE(INDEX) do{ if (e_steps) { e_steps < 0 ? ++e_steps : --e_steps; E0_DIR_WRITE(INVERT_E_STEP_PIN); }while(0) + #endif #else #define START_E_PULSE(INDEX) do{ if (e_steps) E## INDEX ##_STEP_WRITE(!INVERT_E_STEP_PIN); }while(0) #define STOP_E_PULSE(INDEX) do { if (e_steps) { e_steps < 0 ? ++e_steps : --e_steps; E## INDEX ##_STEP_WRITE(INVERT_E_STEP_PIN); } }while(0)