From 595580556c947914d8802be73b907a6aa58fb5d7 Mon Sep 17 00:00:00 2001 From: George Roberts Date: Tue, 10 Sep 2013 09:56:19 -0400 Subject: [PATCH] Fixed bug that makes ulticontroller knob backwards introduced Feb 28 2013 by Robert. Bug introduced in version 6beb42cdf65971aeca93868305ed93ae6ed732eb. Robert did a good job of simplifying but messed up this chunk of code. Looking at working version: 839bef6d5d436055c6cef051b6b32a84bd18d05a it seems there is no case where encrot3 should be defined as 2 because if ULTICONTROLLER is defined then NEWPANEL is also defined. --- Marlin/ultralcd_implementation_hitachi_HD44780.h | 7 ------- 1 file changed, 7 deletions(-) diff --git a/Marlin/ultralcd_implementation_hitachi_HD44780.h b/Marlin/ultralcd_implementation_hitachi_HD44780.h index 9be57a905..ac397f675 100644 --- a/Marlin/ultralcd_implementation_hitachi_HD44780.h +++ b/Marlin/ultralcd_implementation_hitachi_HD44780.h @@ -128,17 +128,10 @@ extern volatile uint16_t buttons; //an extended version of the last checked but // These values are independent of which pins are used for EN_A and EN_B indications // The rotary encoder part is also independent to the chipset used for the LCD #if defined(EN_A) && defined(EN_B) - #ifndef ULTIMAKERCONTROLLER #define encrot0 0 #define encrot1 2 #define encrot2 3 #define encrot3 1 - #else - #define encrot0 0 - #define encrot1 1 - #define encrot2 3 - #define encrot3 2 - #endif #endif #endif //ULTIPANEL