SunRed/SpaceCadetPinball
1
0
Fork 0
mirror of https://github.com/k4zmu2a/SpaceCadetPinball.git synced 2024-12-18 10:37:53 +01:00
Code Issues Releases Activity

Fix flipper animation and angle calculation (#150)

Browse source 
Checked with a slowed down flipper (reduced retractTime and extendTime)
to ensure the flipper position is correct even when not finished while
pressing the flipper control.
This commit is contained in:
Alexis Murzeau 2022-08-09 09:04:51 +02:00 committed by GitHub
parent 367f4538a3
commit a2567c1fea
Signed by: GitHub
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
SpaceCadetPinball/TFlipper.cpp
View file

@ -137,7 +137,7 @@ void TFlipper::TimerExpired(int timerId, void* caller)
auto flip = static_cast<TFlipper*>(caller); auto flip = static_cast<TFlipper*>(caller);
int bmpCountSub1 = flip->ListBitmap->size() - 1; int bmpCountSub1 = flip->ListBitmap->size() - 1;
auto newBmpIndex = static_cast<int>(floor((pb::time_now - flip->InputTime) / flip->TimerTime)); auto newBmpIndex = static_cast<int>(floor(flip->FlipperEdge->flipper_angle(pb::time_now) / flip->FlipperEdge->AngleMax * bmpCountSub1 + 0.5));
if (newBmpIndex > bmpCountSub1) if (newBmpIndex > bmpCountSub1)
newBmpIndex = bmpCountSub1; newBmpIndex = bmpCountSub1;
if (newBmpIndex < 0) if (newBmpIndex < 0)
@ -155,7 +155,7 @@ void TFlipper::TimerExpired(int timerId, void* caller)
} }
if (flip->MessageField == 2) if (flip->MessageField == 2)
{ {
flip->BmpIndex = bmpCountSub1 - newBmpIndex; flip->BmpIndex = newBmpIndex;
if (flip->BmpIndex <= 0) if (flip->BmpIndex <= 0)
{ {
flip->BmpIndex = 0; flip->BmpIndex = 0;

19
SpaceCadetPinball/TFlipperEdge.cpp
View file

@ -418,19 +418,17 @@ float TFlipperEdge::flipper_angle(float timeNow)
{ {
if (!FlipperFlag) if (!FlipperFlag)
return Angle1; return Angle1;
float angle = (Angle1 - Angle2) / AngleMax * AngleMult;
if (angle < 0.0f)
angle = -angle;
if (angle >= 0.0000001f) float currentAngleDuration = fabsf((Angle1 - Angle2) / AngleMax * AngleMult);
angle = (timeNow - InputTime) / angle; float currentAngleRatio;
if (currentAngleDuration >= 0.0000001f)
currentAngleRatio = (timeNow - InputTime) / currentAngleDuration;
else else
angle = 1.0; currentAngleRatio = 1.0;
angle = std::min(1.0f, std::max(angle, 0.0f)); currentAngleRatio = std::min(1.0f, std::max(currentAngleRatio, 0.0f));
if (FlipperFlag == 2) return currentAngleRatio * (Angle1 - Angle2) + Angle2;
angle = 1.0f - angle;
return angle * AngleMax;
} }
int TFlipperEdge::is_ball_inside(float x, float y) int TFlipperEdge::is_ball_inside(float x, float y)
@ -482,7 +480,6 @@ void TFlipperEdge::SetMotion(int code, float value)
default: break; default: break;
} }
if (!FlipperFlag)
InputTime = value; InputTime = value;
FlipperFlag = code; FlipperFlag = code;
AngleStopTime = AngleMult + InputTime; AngleStopTime = AngleMult + InputTime;