Eduardo José Tagle
edb21f349a
Fix stepper/planner block handling, race conditions ( #11098 )
...
- Allow planner to alter the deceleration phase of the currently executing block.
- Remove BUSY flag, as it is NON ATOMIC to set bits in the Stepper ISR and Planner at the same time.
2018-06-27 18:11:16 -05:00
Scott Lahteine
4d3a9930c5
Match ASM comment spacing to 1.1.x
2018-06-27 17:26:48 -05:00
Andy Shaw
3b3029c4bf
Make max_e_jerk an array to reduce CPU usage ( #11118 )
2018-06-26 22:38:31 -04:00
Eduardo José Tagle
48a15d1c7e
[2.0.x] Fix stepper/planner race condition and Stepper pulse timer ( #11081 )
...
* Planner: Removal of some race conditions between Stepper ISR and Planner, some of them pointed out by @AnHardt, some of my own findings
* Fixing timing on stepper pulses adding a compensation for the non-null time required to set ports.
2018-06-22 09:15:37 -05:00
Scott Lahteine
4dbec774b5
HAL_*_TIMER_RATE => *_TIMER_RATE
2018-06-12 16:39:12 -05:00
Scott Lahteine
9d04f47d98
Improvements for junction_deviation_mm
...
- Drop `max_jerk` with `JUNCTION_DEVIATION`
- Add `max_e_jerk_factor` for use by `LIN_ADVANCE`
- Recalculate `max_e_jerk_factor` when `junction_deviation_mm` changes
- Fix LCD editing of `junction_deviation_mm`
2018-06-11 22:05:16 -05:00
Scott Lahteine
a2f521d34b
Add Junction Deviation mm runtime setting ( #10990 )
2018-06-10 18:02:54 -05:00
etagle
39a7e7720d
Adaptive multiaxis step smoothing
...
- Stepper bugs fixed
- Support MIXING_EXTRUDER with Linear Advance
- Miscellaneous cleanup
2018-06-10 16:02:47 -05:00
etagle
d82704354f
Increase the planner first block HOLD delay to 100mS
2018-06-09 21:12:37 -05:00
Eduardo José Tagle
d3c02410a8
[2.0.x] Small assorted collection of fixes and improvements ( #10911 )
...
* Misc fixes and improvements
- Get rid of most critical sections on the Serial port drivers for AVR and DUE. Proper usage of FIFOs should allow interrupts to stay enabled without harm to queuing and dequeuing.
Also, with 8-bit indices (for AVR) and up to 32-bit indices (for ARM), there is no need to protect reads and writes to those indices.
- Simplify the XON/XOFF logic quite a bit. Much cleaner now (both for AVR and ARM)
- Prevent a race condition (edge case) that could happen when estimating the proper value for the stepper timer (by reading it) and writing the calculated value for the time to the next ISR by disabling interrupts in those critical and small sections of the code - The problem could lead to lost steps.
- Fix dual endstops not properly homing bug (maybe).
* Set position immediately when possible
2018-06-01 19:02:22 -05:00
Scott Lahteine
2deff0d9b9
Fix/Improve junction deviation
...
- Respect axis max acceleration limits instead of forcing a fixed acceleration value.
- The `junction_unit_vec` ensures proper handling of entry and exit speeds even when the axes involved have different limits.
2018-05-31 20:09:53 -05:00
Scott Lahteine
8f14ef855d
More concise commentary in planner.cpp
2018-05-28 19:25:18 -05:00
Scott Lahteine
931ab4ec40
Rename Junction Deviation options
2018-05-26 18:33:51 -05:00
Scott Lahteine
aaaf09bda2
BEZIER_JERK_CONTROL => S_CURVE_ACCELERATION
2018-05-26 18:33:51 -05:00
Scott Lahteine
435ecb6b67
Followup to stepper/planner refactor
2018-05-20 23:13:38 -05:00
etagle
569df3fc0c
Fix interrupt-based endstop detection
...
- Also implemented real endstop reading on interrupt.
2018-05-20 07:10:24 -05:00
etagle
a4af975873
Fix planner block optimization
...
- Fixed the planner incorrectly avoiding optimization of the block following the active one.
- Added extra conditions to terminate planner early and avoid redundant computations.
2018-05-20 07:10:24 -05:00
etagle
e0ca627033
Planner block HOLD flag
...
Allows the Stepper ISR to wait until a given block is free for use. Allows Planner to plan the first move, which is split into two.
2018-05-20 06:23:58 -05:00
etagle
a11eb50a3e
Refactor and optimize Stepper/Planner
...
Better encapsulation and considerably reduce stepper jitter
2018-05-20 06:23:58 -05:00
Jiri Jaburek
43ddb29f9e
Add FAN_MAX_PWM for M106-controlled fans
2018-05-15 21:18:46 -05:00
Scott Lahteine
08e36e264e
Apply _AXIS macro
2018-05-13 06:51:01 -05:00
Scott Lahteine
99ecdf59af
Smarter MIN, MAX, ABS macros
...
Use macros that explicitly avoid double-evaluation and can be used for any datatype, replacing `min`, `max`, `abs`, `fabs`, `labs`, and `FABS`.
Co-Authored-By: ejtagle <ejtagle@hotmail.com>
2018-05-13 04:52:56 -05:00
Scott Lahteine
8f8c6a9bc4
Move get_axis_position_mm to Planner ( #10718 )
2018-05-12 09:59:11 -05:00
Scott Lahteine
306f0f2135
Move Stepper::synchronize to Planner ( #10713 )
...
Co-Authored-By: ejtagle <ejtagle@hotmail.com>
2018-05-12 01:38:02 -05:00
Scott Lahteine
439e0cdd0f
Patch up reverse_pass_kernel (and other planner code) ( #10674 )
2018-05-10 01:30:55 -05:00
Scott Lahteine
57c2f8d2f6
Trailing whitespace cleanup
2018-05-10 00:17:10 -05:00
Scott Lahteine
19f189b4e5
Add UBL support for G2/G3 and G5 ( #10648 )
2018-05-08 11:10:45 -05:00
Scott Lahteine
4d4bf7897d
Junction Deviation jerk limiting option
2018-05-08 10:08:54 -05:00
Scott Lahteine
0436e16fb2
Apply shorthand Assembler macros
2018-05-08 10:08:54 -05:00
Scott Lahteine
d1b619be52
Standardize some hexadecimals
2018-05-08 09:19:18 -05:00
Scott Lahteine
1f11b0f612
Fully init planner sync block
2018-05-06 08:16:54 -05:00
Scott Lahteine
af1950a63e
Improve sync of stepper positions
2018-05-06 01:24:14 -05:00
Scott Lahteine
f423e54f77
Strip trailing spaces
2018-04-23 18:00:43 -05:00
Scott Lahteine
5a064d0e94
Fix bug in planner.set_position_mm
2018-04-16 04:19:58 -05:00
Scott Lahteine
8f57e098de
Use end-of-line comments in planner.cpp
2018-04-15 19:02:30 -05:00
Scott Lahteine
36b97bde9f
clear_block_buffer, kill_current_block in quick_stop
2018-04-13 22:04:53 -05:00
Eduardo José Tagle
57a899a412
[2.0.x] 6th-order jerk-controlled motion planning in real-time for AVR ( #10373 )
2018-04-11 18:13:42 -05:00
etagle
a29adde5c0
Implement BEZIER_JERK_CONTROL
...
Enable 6th-order jerk-controlled motion planning in real-time.
Only for 32bit MCUs. (AVR simply does not have enough processing power for this!)
2018-04-07 21:03:28 -05:00
Scott Lahteine
e8e60263c8
Scale feedrate (mm/s to deg/s) for SCARA
2018-04-06 19:47:48 -05:00
Scott Lahteine
fe91514395
MBL should add z_offset regardless of fade ( #10308 )
2018-04-04 18:57:33 -05:00
Scott Lahteine
ac7e97f4fe
Change order of inactive stepper disable/enable
...
This ensures that steppers that share an enable pin will only be disabled for a miniscule time.
2018-03-30 15:07:38 -05:00
Scott Lahteine
1cb810ff1c
[2.0.x] Automatically reset stepper timeout ( #10179 )
...
* Automatically reset stepper timeout in manage_inactivity
Any code that adds moves to the planner can skip resetting the stepper timeout. We can let `idle` / `manage_inactivity` reset the timer whenever it detects any moves in the planner.
* blocks_queued => has_blocks_queued
2018-03-21 19:30:06 -05:00
Scott Lahteine
3c2bfa5e53
Update powersupply_on in power_on/off ( #10015 )
...
Fix #10004
2018-03-08 18:56:47 -06:00
Scott Lahteine
930720bbbb
Fix broken reverse planner ( #9943 )
...
From #9914 by @Sebastianv650
2018-03-04 21:19:06 -06:00
Scott Lahteine
d1dc863962
autotemp_factor is not value_celsius_diff
...
See https://github.com/MarlinFirmware/Marlin/issues/9852#issuecomment-369861822
2018-03-03 23:27:54 -06:00
Scott Lahteine
689bc99402
Correction to acceleration
2018-02-24 11:09:36 -06:00
Scott Lahteine
2bd252b501
[2.0.x] LIN_ADVANCE v1.5 ( #9712 )
2018-02-23 00:53:29 -06:00
Scott Lahteine
73cd34b121
Finish AUTO_POWER_CONTROL implementation
...
Followup to #9503
2018-02-19 16:12:04 -06:00
Thomas Moore
786746404b
[2.0.x] Apply feedrate to nozzle movement for kinematic machines ( #8778 )
2018-02-04 00:26:05 -06:00
Scott Lahteine
9644fe1839
Lightly optimize arc length calculation
2018-01-23 19:13:59 -06:00
Scott Lahteine
4f5e087ff4
Planner anti-stutter by Sebastian Popp
2018-01-14 21:07:10 -06:00
Scott Lahteine
5effe1590c
Fix NO_VOLUMETRICS bug
2017-12-26 20:04:44 -06:00
Thomas Moore
2917d1217d
Revert "Followup to #8698 "
...
This reverts commit 4e891e9fb7
.
2017-12-23 17:00:33 -06:00
Scott Lahteine
97d509d4d2
Revert "Improved Core-compatible jerk code"
...
Reverting commit 3cd7659
2017-12-21 16:54:30 -06:00
Scott Lahteine
5bc2acc072
Restore position_float to fix LIN_ADVANCE
2017-12-21 16:45:46 -06:00
Scott Lahteine
913d9e9a59
Matching sign across filwidth vars
2017-12-20 00:17:19 -06:00
Scott Lahteine
933f76fda3
Option to disable all volumetric extrusion
2017-12-19 19:51:25 -06:00
Scott Lahteine
de5ca96654
More parity with 1.1.x, plus whitespace
2017-12-19 18:36:16 -06:00
Scott Lahteine
cf2193c07f
Comment, fix filament width sensor
2017-12-13 02:32:34 -06:00
Scott Lahteine
3255712343
Skew Correction for UBL
...
Also remove unused grid slicing function when using UBL segmented.
2017-12-11 03:08:15 -06:00
Scott Lahteine
3db5303bfe
_buffer_line => buffer_segment
2017-12-11 00:27:06 -06:00
Scott Lahteine
a71d2f3f40
UBL_DELTA => UBL_SEGMENTED
2017-12-11 00:27:06 -06:00
Scott Lahteine
73e32925e4
References are better for array args
2017-12-11 00:27:06 -06:00
AnHardt
b3daf6b5db
[2.0.x] better reverse pass ( #8722 )
...
* repair reverse_pass()
And make it readeble.
This was broken a long time ago.
Not competely unfunctional but far from optimal.
* Minor speedup when calling calculate_trapezoid_for_block
2 float / to 1 foat / and 2 float *
* Various style changes
2017-12-08 21:38:45 -06:00
Bob-the-Kuhn
65d0f32f82
divide only when required
2017-12-08 18:14:27 -06:00
Scott Lahteine
85c6ffbe0d
Discard all "continued" blocks on interrupted move
2017-12-08 02:32:58 -06:00
Scott Lahteine
4e891e9fb7
Followup to #8698
2017-12-08 01:01:12 -06:00
Scott Lahteine
3cd7659924
Improved Core-compatible jerk code
2017-12-06 23:57:57 -06:00
Scott Lahteine
840289e7cc
Use block cleaning instead of split flag
2017-12-06 22:22:58 -06:00
Scott Lahteine
2fde60da12
Changes for parity with 1.1.x
2017-12-06 21:50:54 -06:00
AnHardt
a993c5227d
Don't split first_move while homing or probing
...
While homing or probing it might be bad if the stop/trobe triggers during the first part and the second is still in the buffer.
2017-12-06 14:13:05 +01:00
Scott Lahteine
5fbb2f121e
Remove skew warning that could crash the planner
2017-12-05 20:27:20 -06:00
Scott Lahteine
d8b444c144
Cleanup constextpr in planner.cpp
2017-12-05 18:55:57 -06:00
Scott Lahteine
53694ebaa1
Folllwup to planner splitting
2017-12-04 18:55:23 -06:00
Scott Lahteine
4b612f590c
Split first move to planner for better chaining
2017-12-04 15:27:47 -06:00
Scott Lahteine
dd8febca1a
Revert "Merge pull request #8611 from thinkyhead/bf2_planner_split_first"
...
This reverts commit 824980e70e
, reversing
changes made to aa7efb96bf
.
2017-12-03 17:50:19 -06:00
Scott Lahteine
3a97de52ef
Split first move to planner for better chaining
...
Address #8573 , #8595
2017-12-03 01:27:14 -06:00
Scott Lahteine
8056120195
Rename inverse_mm_s => inverse_secs
2017-12-02 20:28:09 -06:00
Scott Lahteine
23557f8e77
Remove obsolete de_float
2017-12-02 20:23:10 -06:00
Scott Lahteine
0154e3480c
New feature: BED_SKEW_CORRECTION
2017-12-01 19:39:49 -06:00
Scott Lahteine
dd3ce40826
Drop Planner::position_float, use int types
2017-11-30 17:43:31 -06:00
Scott Lahteine
ec6ca37ed3
Fix (un)apply_leveling fade bug
2017-11-30 17:25:44 -06:00
Scott Lahteine
a52fec6ac4
Planner class parity with 1.1.x
2017-11-30 15:55:08 -06:00
Scott Lahteine
23e45fa3c4
Apply const to some planner vars
2017-11-29 21:02:55 -06:00
Scott Lahteine
285b868e9b
Tweak planner code style
2017-11-29 15:22:18 -06:00
Scott Lahteine
1f2acc33bc
Tweaks for check_axes_activity
2017-11-28 18:41:13 -06:00
Scott Lahteine
16baa48699
Fix #8579
...
Fan speed code fell into a curly brace
2017-11-28 16:12:14 -06:00
Scott Lahteine
27c5692b13
Syntax tweaks
2017-11-25 18:13:36 -06:00
Scott Lahteine
a03f93bab4
Fix fan kickstart
2017-11-23 21:42:45 -06:00
Scott Lahteine
9e3c41f9e8
Tweak fan kickstart / speed code
2017-11-23 15:20:35 -06:00
Scott Lahteine
60adc6ff02
Display filwidth ratio in terms of E mm
2017-11-18 07:01:49 -06:00
Scott Lahteine
50f09cc029
Miscellaneous cleanup
2017-11-16 00:47:16 -06:00
Scott Lahteine
cba9c1cf9e
Add pre-calculated planner.e_factor
2017-11-10 03:14:24 -06:00
Thomas Moore
600c85226e
Normalize load/unload length in M600
2017-11-10 02:31:46 -06:00
Scott Lahteine
f8393a0908
Operate in Native Machine Space
2017-11-04 00:05:38 -05:00
Scott Lahteine
3e8754a38a
Add/correct time units on planner vars / M205 B
2017-10-29 18:47:21 -05:00
Scott Lahteine
3e3911fb81
Use planner.leveling_active for all leveling systems
2017-10-14 02:18:31 -05:00
Scott Lahteine
ca1e47375c
Move fade_scaling_factor_for_z to Planner
2017-10-14 02:18:31 -05:00
Scott Lahteine
9a930ebec2
Make leveling_is_active a macro
2017-10-14 02:18:31 -05:00
Scott Lahteine
1adb5a6a48
Remove obsolete UBL z_offset
2017-10-13 08:22:46 -05:00
Scott Lahteine
03f4891fb9
Remove legacy ADVANCE feature
2017-10-09 04:25:18 -05:00
Scott Lahteine
a10451ceed
Move Volumetric methods to Planner
2017-09-21 16:27:11 -05:00
Scott Lahteine
1a37ebc76d
Move M163-M165 MIXING_EXTRUDER to cpp
2017-09-21 16:27:10 -05:00
Scott Lahteine
b464887ea1
Make BARICUDA a feature
2017-09-21 16:26:57 -05:00
Scott Lahteine
4f1eadf41f
FILAMENT_WIDTH_SENSOR feature
2017-09-21 16:26:48 -05:00
Scott Lahteine
551752eac7
Consolidate "bedlevel" code
2017-09-21 16:26:47 -05:00
Scott Lahteine
bf7af95db3
Move flow_percentage to Planner
2017-09-21 16:26:46 -05:00
Scott Lahteine
722786966a
Add gcode.cpp, motion.*, queue.* - Apply to some G-codes.
2017-09-21 16:26:45 -05:00
Scott Lahteine
3d8a0ab4b2
Module updates
2017-09-21 16:26:42 -05:00
Scott Lahteine
0c9231fd04
Move 'module' files
2017-09-12 14:51:05 -05:00